Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gift card activation #716

Open
dt2patel opened this issue Aug 23, 2024 · 6 comments
Open

Gift card activation #716

dt2patel opened this issue Aug 23, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request release-v2.8.1

Comments

@dt2patel
Copy link
Contributor

dt2patel commented Aug 23, 2024

Add the ability to do gift card activation in Shopify directly from fulfillment app. Details included in implementation doc:

https://docs.google.com/document/d/1dWb8ojd_--99yNzF8U1J8FDM9E9npbeAIuofmPmENbM/edit?usp=sharing

@dt2patel dt2patel added the enhancement New feature or request label Aug 23, 2024
@amansinghbais amansinghbais self-assigned this Aug 28, 2024
amansinghbais added a commit to amansinghbais/fulfillment-pwa that referenced this issue Aug 29, 2024
amansinghbais added a commit to amansinghbais/fulfillment-pwa that referenced this issue Aug 29, 2024
amansinghbais added a commit to amansinghbais/fulfillment-pwa that referenced this issue Aug 29, 2024
amansinghbais added a commit to amansinghbais/fulfillment-pwa that referenced this issue Aug 30, 2024
amansinghbais added a commit to amansinghbais/fulfillment-pwa that referenced this issue Sep 2, 2024
amansinghbais added a commit to amansinghbais/fulfillment-pwa that referenced this issue Sep 2, 2024
amansinghbais added a commit to amansinghbais/fulfillment-pwa that referenced this issue Sep 2, 2024
ravilodhi added a commit that referenced this issue Sep 2, 2024
Implemented: added support for gift card activation (#716)
amansinghbais added a commit to amansinghbais/fulfillment-pwa that referenced this issue Sep 10, 2024
ravilodhi added a commit that referenced this issue Sep 10, 2024
Improved: sending customer partyId as payload for activating gift card (#716)
@Adameddy26
Copy link

There is no gift card available to verify this ticket. Therefore, marking this ticket on-hold.

@dt2patel
Copy link
Contributor Author

dt2patel commented Oct 4, 2024

@Adameddy26 what is your plan to be able to test this with a gift card? it's been 3 weeks

@Adameddy26
Copy link

@dt2patel I encountered few doubts while checking this functionality.

  1. Should we allow the user to generate the gift card activation from the open orders page or the completed orders page?

  2. Can we remove the box chip and report an issue icon from the gift card item record? If we retain the option to change the box or report an issue for the gift card, will changing the box or reporting an issue result in the activation code being voided?

  3. Can we display the gift card activation code associated with the order item directly in the order details within the OMS?

  4. If the same gift card is added multiple times in an order, is it acceptable to assign the same activation code to all the cards, or should there be a validation process to prevent this?

@dt2patel
Copy link
Contributor Author

  1. Yes they can do it from anywhere at this time. No planned restrictions
  2. I understand this, and you're right that this experience needs to be thought through. Please start a new ticket for this.
  3. Yes we could add a card for this. Please start a new ticket for this
  4. The user should not use the same gift card on all cards. We will have to think this through. Please start a new ticket for this.

@amansinghbais
Copy link
Contributor

amansinghbais commented Oct 17, 2024

@dt2patel sir,

Currently we have gift card activation button on the order details page (all open, inprogress and completed orders) and on the Inprogress orders list page. Currently user can't activate gift card from open and completed orders list page. If we want we can add the activation button on Open and Completed orders list page too.

@dt2patel
Copy link
Contributor Author

That's ok, for now the current implementation is ok. I will think through this in detail before requesting any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-v2.8.1
Projects
Status: 🛠 In QA
Development

No branches or pull requests

4 participants