-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mapper frontend using ElectricSQL ShapeStream (live updates) #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0629493
to
ed06ff6
Compare
abd44fa
to
c338efc
Compare
c632e46
to
aa03414
Compare
6051b89
to
cd49b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Related to backend code
devops
Related to deployment or configuration
enhancement
New feature or request
frontend
Related to frontend code
migration
Contains a DB migration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Foundation for issues in milestone: https://github.com/hotosm/fmtm/milestone/36
Related to #1604
Describe this PR
mapnow/{projectId}
mapper frontend (a self-contained Svelte web app).TODO:
@hotosm/ui
is using a relative path to dependency.Screenshots
Review Guide
Testing this will require:
installing frontend deps locally:
cd src/mapper pnpm install
image builds + probably clearing existing data:
I'm not expecting a comprehensive review of this - it will likely not be perfect on first attempt.
Instead I propose we test it roughly, merge it in, then iterate / improve. Bugs can be fixed as we go.
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?