feat: auto get base branch for create PR/MR #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotoo
force-pushed
the
feat/mr-basebranch
branch
from
9aa32bf to
b10d5cb
Compare
|
应该是 close issue 吧 |
nightink
reviewed
Feb 22, 2017
| .filter(function(branchName) { | ||
| return branchName !== cwb; | ||
| }); | ||
| return baseBranches.length >= 0 ? [baseBranches[0]] : []; |
Owner
Author
There was a problem hiding this comment.
理论上来说，target branch 的来源分支应该可以有多个，最近的排第一个，但是还没完全搞清楚过滤这些分支的准确方法，所以预留了。
nightink
reviewed
Feb 22, 2017
bin/open-commander.js
Outdated
| // return name !== option.cwb; | ||
| // }); | ||
| } | ||
| if (remoteBranchLength > 1) { |
Owner
Author
There was a problem hiding this comment.
现在走不到。预留的，之前想如果拿不到则拿所有的远程分支供选择。
|
+1 |
hotoo
force-pushed
the
feat/mr-basebranch
branch
from
b10d5cb to
68a2c37
Compare
Owner
Author
|
2.7.0 |
hotoo
added a commit
that referenced
this pull request
Mar 3, 2017
feat: auto get base branch for create PR/MR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #47
This PR is create by
gitopen pr