-
Notifications
You must be signed in to change notification settings - Fork 3
WHERE condition parser #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @lmangani! Thanks for the contribution, this looks really cool! I just kicked off the tests, assuming those all pass I'll get this merged |
|
The changes build and pass locally using v1.3.0 as baseline, I'll check out what's wrong with the builder/action EDIT: I see the issue is simply with the "next" builder - changes related to 1.4.0 in main which affect the existing code as well. The v1.3.0 build should pass smoothly. |
|
@zacMode any thoughts or change requests? |
|
Apologies for the delay @lmangani ! I was hoping to have time this weekend to look into the "next build" stuff (at least to understand what it'll take to fix it), but didn't get to it. I'll go ahead and merge and fix at a later time. Thanks for your patience (and contribution)! |
|
Thanks @zacMode for accepting the PR! I'm looking forward to using the next extension release in our workflows! |
Includes new "WHERE" condition parser capabilities: hotdata-dev/duckdb_extension_parser_tools#1
Hey @zacMode 👋 Just discovered this extension and its super useful! I'm not sure if this is even compatible in intention with your roadmap (absolutely no offense if not) but were about to expose a similarly simple
whereparser in our chsql quackscience community extension but now it seems more appropriate to perhaps have this as part of this dedicated one, so here's a little PR + Tests extension just for discussion.