nix: factor out repeated code into configurePhase (prisma#3653)

That way, only one derivation has to worry about setting up the dependencies.
hostbee · Jan 31, 2023 · f2fdde4 · f2fdde4
1 parent 2160401
commit f2fdde4
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 23 deletions.
diff --git a/nix/all-engines.nix b/nix/all-engines.nix
@@ -20,7 +20,6 @@ let
   libSuffix = if stdenv.isDarwin then "dylib" else "so";
 in
 {
-  packages.prisma-engines-deps = deps;
   packages.prisma-engines = stdenv.mkDerivation {
     name = "prisma-engines";
     inherit src;
@@ -37,9 +36,12 @@ in
       darwin.apple_sdk.frameworks.Security
     ];
 
-    buildPhase = ''
+    configurePhase = ''
       mkdir .cargo
       ln -s ${deps}/config.toml .cargo/config.toml
+    '';
+
+    buildPhase = ''
       cargo build --release --bins
       cargo build --release -p query-engine-node-api
     '';
@@ -58,13 +60,9 @@ in
     ({ profile }: stdenv.mkDerivation {
       name = "test-cli";
       inherit src;
-      inherit (self'.packages.prisma-engines) buildInputs nativeBuildInputs;
+      inherit (self'.packages.prisma-engines) buildInputs nativeBuildInputs configurePhase;
 
-      buildPhase = ''
-        mkdir .cargo
-        ln -s ${deps}/config.toml .cargo/config.toml
-        cargo build --profile=${profile} --bin=test-cli
-      '';
+      buildPhase = "cargo build --profile=${profile} --bin=test-cli";
 
       installPhase = ''
         set -eu
@@ -79,13 +77,9 @@ in
     ({ profile }: stdenv.mkDerivation {
       name = "query-engine-bin";
       inherit src;
-      inherit (self'.packages.prisma-engines) buildInputs nativeBuildInputs;
+      inherit (self'.packages.prisma-engines) buildInputs nativeBuildInputs configurePhase;
 
-      buildPhase = ''
-        mkdir .cargo
-        ln -s ${deps}/config.toml .cargo/config.toml
-        cargo build --profile=${profile} --bin=query-engine
-      '';
+      buildPhase = "cargo build --profile=${profile} --bin=query-engine";
 
       installPhase = ''
         set -eu

diff --git a/nix/cargo-doc.nix b/nix/cargo-doc.nix
@@ -3,13 +3,9 @@
 {
   packages.cargo-docs = pkgs.clangStdenv.mkDerivation {
     name = "prisma-engines-cargo-docs";
-    inherit (self'.packages.prisma-engines) buildInputs nativeBuildInputs src;
+    inherit (self'.packages.prisma-engines) buildInputs nativeBuildInputs src configurePhase;
 
-    buildPhase = ''
-      mkdir .cargo
-      ln -s ${self'.packages.prisma-engines-deps}/config.toml .cargo/config.toml
-      cargo doc --workspace
-    '';
+    buildPhase = "cargo doc --workspace";
 
     installPhase = ''
       mkdir -p $out/share

diff --git a/nix/prisma-fmt-wasm.nix b/nix/prisma-fmt-wasm.nix
@@ -2,18 +2,16 @@
 
 let
   toolchain = pkgs.rust-bin.fromRustupToolchainFile ../prisma-fmt-wasm/rust-toolchain.toml;
-  deps = self'.packages.prisma-engines-deps;
   scriptsDir = ../prisma-fmt-wasm/scripts;
   inherit (pkgs) jq nodejs coreutils wasm-bindgen-cli stdenv;
   inherit (builtins) readFile replaceStrings;
 in
 {
   packages.prisma-fmt-wasm = stdenv.mkDerivation {
     name = "prisma-fmt-wasm";
-    src = ../.;
     nativeBuildInputs = with pkgs; [ git wasm-bindgen-cli toolchain ];
+    inherit (self'.packages.prisma-engines) configurePhase src;
 
-    configurePhase = "mkdir .cargo && ln -s ${deps}/config.toml .cargo/config.toml";
     buildPhase = "cargo build --release --target=wasm32-unknown-unknown -p prisma-fmt-build";
     installPhase = readFile "${scriptsDir}/install.sh";
   };