-
Notifications
You must be signed in to change notification settings - Fork 299
feat: add italian translation #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, Thank you for the PR.
No,
Please follow the English translation.
Your idea of conditionating translations is really good, If you don't mind, Please create a new issue for that (Feature Request). |
@hossein-zare : The problem if I had to follow the English translation would not be very correct in Italian, it is difficult to explain. |
Okay, We had the same problem with the Russian translation. |
@hossein-zare : Ok, I don't really like it as a linguistic form, but I tried to follow the Spanish example. |
@Angelk90 Thank you. |
Is it ok now? |
@hossein-zare : Updated. |
Hi @hossein-zare , could you check if line 47 of the
src/translations/index.js
control was written correctly, I had to improvise a little.