Skip to content

feat: add italian translation #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2022
Merged

feat: add italian translation #524

merged 4 commits into from
Mar 28, 2022

Conversation

Angelk90
Copy link
Contributor

Hi @hossein-zare , could you check if line 47 of the src/translations/index.js control was written correctly, I had to improvise a little.

@hossein-zare
Copy link
Owner

Hi,

Thank you for the PR.

could you check if line 47 of the src/translations/index.js control was written correctly, I had to improvise a little.

No, {count} is replaced using the String.prototype.replace() method so you can't do {count} === 1.

return _multipleText.replace('{count}', item.length);

Please follow the English translation.

SELECTED_ITEMS_COUNT_TEXT: '{count} item(s) have been selected',

Your idea of conditionating translations is really good, If you don't mind, Please create a new issue for that (Feature Request).
That won't be possible but alternative solutions will be introduced.

@Angelk90
Copy link
Contributor Author

@hossein-zare : The problem if I had to follow the English translation would not be very correct in Italian, it is difficult to explain.
I can do it anyway, we will see to fix it in the future.

@hossein-zare
Copy link
Owner

Okay, We had the same problem with the Russian translation.

@Angelk90
Copy link
Contributor Author

Angelk90 commented Mar 27, 2022

@hossein-zare : Ok, I don't really like it as a linguistic form, but I tried to follow the Spanish example.

@hossein-zare
Copy link
Owner

@Angelk90
I'm going to mark your PR as pending and improve the translation system.
Later i'll ask you to update your translation.

Thank you.

@hossein-zare hossein-zare added the pending merge just waiting for CI or final feedback, but will be merged label Mar 27, 2022
@hossein-zare
Copy link
Owner

@Angelk90

Is it ok now?

@hossein-zare hossein-zare removed the pending merge just waiting for CI or final feedback, but will be merged label Mar 27, 2022
@Angelk90
Copy link
Contributor Author

@hossein-zare : Updated.

@hossein-zare hossein-zare merged commit 743acd6 into hossein-zare:dev-5.x Mar 28, 2022
@hossein-zare hossein-zare mentioned this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants