Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved retry #6

Merged
merged 1 commit into from
Oct 27, 2015
Merged

improved retry #6

merged 1 commit into from
Oct 27, 2015

Conversation

bbihari
Copy link
Contributor

@bbihari bbihari commented Oct 26, 2015

@doktoric @lalyos plz check

while :; do
[[ $ret > $maxret ]] && return 1;
echo "${ret}.retry...";
eval "$@" && return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a || exitCode=$? at the end of eval, and followed by an echo "---> command failed with exit code: $exitCode" 1>&2 would help to debug the issue what causes the retry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Fixed.

@lalyos
Copy link
Contributor

lalyos commented Oct 27, 2015

LGTM

lalyos added a commit that referenced this pull request Oct 27, 2015
@lalyos lalyos merged commit bddc781 into master Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants