Add a unit test using a dataset with a field order different than in … #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2018 11:08
sbarnoud
pushed a commit
to sbarnoud/shc
that referenced
this pull request
Apr 19, 2018
I don't understand why using the row.toSeq.iterator fails in my environment I added the Unit test hortonworks-spark#247 showing that the problem doesn't exists in Travis See https://travis-ci.org/hortonworks-spark/shc/builds/368556158 => the Unit test fails without the patch, and succeed with. But stills fails in my environment ...
|
This test willingly fails to show that Avro serialization depends on field order in the dataset, which in my opinion is not the expexted bahavior. I propose in #248 a patch for that problem |
|
May i have a feedback? Travis failed, but this is normal, the test is just intended for that, and a PR propose a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the Avro schema
What changes were proposed in this pull request?
Added unit test to expose Avro field order problem
How was this patch tested?
NA