Fix new line conversion corner case #2
Conversation
| * | ||
| * @var string | ||
| */ | ||
| protected $_split = null; |
There was a problem hiding this comment.
Why did you remove the $_split property?
There was a problem hiding this comment.
The previous implementation saved the target EOL first character in this property. To my understanding this was wrong as we are searching for source EOLs.
My implementation uses the _prependNext property to keep track of a carriage return at the end of a bucket when we are searching for CR+LF EOLs.
test/Horde/Stream/Filter/EolTest.php
Outdated
| public static function lineEndingProvider() | ||
| { | ||
| return array( | ||
| array("\r", "ABCDEFGHI"), |
There was a problem hiding this comment.
I changed the strings to use escaped notation for carriage returns.
test/Horde/Stream/Filter/EolTest.php
Outdated
|
|
||
| public function testUnixStyleNewLineSubstitution() | ||
| { | ||
| $test = str_repeat(str_repeat("A", 1) . "\r\n", 4000); |
There was a problem hiding this comment.
str_repeat(...,1) doesn't make much sense.
There was a problem hiding this comment.
That was a left over from the developing phase. Fixed. Thanks
bsod85
force-pushed
the
fix_new_line_conversion_corner_case
branch
from
af2f761 to
4119618
Compare
|
|
||
| public function testUnixStyleNewLineSubstitution() | ||
| { | ||
| $test = str_repeat("A\r\n", 4000); |
There was a problem hiding this comment.
this test string needs to be bigger than a stream bucket and the carriage return needs to be at the end of a bucket
2 participants
No description provided.