[CALCITE-4314] Add missing @OverRide annotations

hoperunChen · Oct 6, 2020 · 66caa54 · 66caa54
1 parent 36b31ba
commit 66caa54
Show file tree

Hide file tree

Showing 745 changed files with 4,490 additions and 4,456 deletions.
diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraEnumerator.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraEnumerator.java
@@ -61,7 +61,7 @@ class CassandraEnumerator implements Enumerator<Object> {
    *
    * @return A new row from the results
    */
-  public Object current() {
+  @Override public Object current() {
     if (fieldTypes.size() == 1) {
       // If we just have one field, produce it directly
       return currentRowField(0);
@@ -123,7 +123,7 @@ private Object convertToEnumeratorObject(Object obj) {
     return obj;
   }
 
-  public boolean moveNext() {
+  @Override public boolean moveNext() {
     if (iterator.hasNext()) {
       current = iterator.next();
       return true;
@@ -132,11 +132,11 @@ public boolean moveNext() {
     }
   }
 
-  public void reset() {
+  @Override public void reset() {
     throw new UnsupportedOperationException();
   }
 
-  public void close() {
+  @Override public void close() {
     // Nothing to do here
   }
 }
diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java
@@ -90,13 +90,13 @@ public CassandraFilter(
     return super.computeSelfCost(planner, mq).multiplyBy(0.1);
   }
 
-  public CassandraFilter copy(RelTraitSet traitSet, RelNode input,
+  @Override public CassandraFilter copy(RelTraitSet traitSet, RelNode input,
       RexNode condition) {
     return new CassandraFilter(getCluster(), traitSet, input, condition,
         partitionKeys, clusteringKeys, implicitFieldCollations);
   }
 
-  public void implement(Implementor implementor) {
+  @Override public void implement(Implementor implementor) {
     implementor.visitChild(0, getInput());
     implementor.add(null, Collections.singletonList(match));
   }

diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraLimit.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraLimit.java
@@ -54,7 +54,7 @@ public CassandraLimit(RelOptCluster cluster, RelTraitSet traitSet,
     return new CassandraLimit(getCluster(), traitSet, sole(newInputs), offset, fetch);
   }
 
-  public void implement(Implementor implementor) {
+  @Override public void implement(Implementor implementor) {
     implementor.visitChild(0, getInput());
     if (offset != null) {
       implementor.offset = RexLiteral.intValue(offset);
@@ -64,7 +64,7 @@ public void implement(Implementor implementor) {
     }
   }
 
-  public RelWriter explainTerms(RelWriter pw) {
+  @Override public RelWriter explainTerms(RelWriter pw) {
     super.explainTerms(pw);
     pw.itemIf("offset", offset, offset != null);
     pw.itemIf("fetch", fetch, fetch != null);

diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraProject.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraProject.java
@@ -57,7 +57,7 @@ public CassandraProject(RelOptCluster cluster, RelTraitSet traitSet,
     return super.computeSelfCost(planner, mq).multiplyBy(0.1);
   }
 
-  public void implement(Implementor implementor) {
+  @Override public void implement(Implementor implementor) {
     implementor.visitChild(0, getInput());
     final CassandraRules.RexToCassandraTranslator translator =
         new CassandraRules.RexToCassandraTranslator(

diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchemaFactory.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchemaFactory.java
@@ -30,7 +30,7 @@ public class CassandraSchemaFactory implements SchemaFactory {
   public CassandraSchemaFactory() {
   }
 
-  public Schema create(SchemaPlus parentSchema, String name,
+  @Override public Schema create(SchemaPlus parentSchema, String name,
       Map<String, Object> operand) {
     Map map = (Map) operand;
     String host = (String) map.get("host");

diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSort.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSort.java
@@ -59,7 +59,7 @@ public CassandraSort(RelOptCluster cluster, RelTraitSet traitSet,
     return new CassandraSort(getCluster(), traitSet, input, collation);
   }
 
-  public void implement(Implementor implementor) {
+  @Override public void implement(Implementor implementor) {
     implementor.visitChild(0, getInput());
 
     List<RelFieldCollation> sortCollations = collation.getFieldCollations();

diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraTable.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraTable.java
@@ -70,11 +70,11 @@ public CassandraTable(CassandraSchema schema, String columnFamily) {
     this(schema, columnFamily, false);
   }
 
-  public String toString() {
+  @Override public String toString() {
     return "CassandraTable {" + columnFamily + "}";
   }
 
-  public RelDataType getRowType(RelDataTypeFactory typeFactory) {
+  @Override public RelDataType getRowType(RelDataTypeFactory typeFactory) {
     if (protoRowType == null) {
       protoRowType = schema.getRelDataType(columnFamily, view);
     }
@@ -191,7 +191,7 @@ public Enumerable<Object> query(final Session session, List<Map.Entry<String, Cl
     final String query = queryBuilder.toString();
 
     return new AbstractEnumerable<Object>() {
-      public Enumerator<Object> enumerator() {
+      @Override public Enumerator<Object> enumerator() {
         final ResultSet results = session.execute(query);
         // Skip results until we get to the right offset
         int skip = 0;
@@ -204,12 +204,12 @@ public Enumerator<Object> enumerator() {
     };
   }
 
-  public <T> Queryable<T> asQueryable(QueryProvider queryProvider,
+  @Override public <T> Queryable<T> asQueryable(QueryProvider queryProvider,
       SchemaPlus schema, String tableName) {
     return new CassandraQueryable<>(queryProvider, schema, this, tableName);
   }
 
-  public RelNode toRel(
+  @Override public RelNode toRel(
       RelOptTable.ToRelContext context,
       RelOptTable relOptTable) {
     final RelOptCluster cluster = context.getCluster();
@@ -227,7 +227,7 @@ public CassandraQueryable(QueryProvider queryProvider, SchemaPlus schema,
       super(queryProvider, schema, table, tableName);
     }
 
-    public Enumerator<T> enumerator() {
+    @Override public Enumerator<T> enumerator() {
       //noinspection unchecked
       final Enumerable<T> enumerable =
           (Enumerable<T>) getTable().query(getSession());

diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraTableScan.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraTableScan.java
@@ -71,7 +71,7 @@ protected CassandraTableScan(RelOptCluster cluster, RelTraitSet traitSet,
     }
   }
 
-  public void implement(Implementor implementor) {
+  @Override public void implement(Implementor implementor) {
     implementor.cassandraTable = cassandraTable;
     implementor.table = table;
   }

diff --git a/...ra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraToEnumerableConverter.java b/...ra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraToEnumerableConverter.java
@@ -68,7 +68,7 @@ protected CassandraToEnumerableConverter(
     return super.computeSelfCost(planner, mq).multiplyBy(.1);
   }
 
-  public Result implement(EnumerableRelImplementor implementor, Prefer pref) {
+  @Override public Result implement(EnumerableRelImplementor implementor, Prefer pref) {
     // Generates a call to "query" with the appropriate fields and predicates
     final BlockBuilder list = new BlockBuilder();
     final CassandraRel.Implementor cassandraImplementor = new CassandraRel.Implementor();