Skip to content

Add delete job function #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

Add delete job function #2

merged 2 commits into from
Dec 12, 2023

Conversation

dartushd
Copy link

@dartushd dartushd commented Oct 24, 2023 •
edited
Loading

Will delete single job when jobId is provided.
WIll delete all jobs.

@dartushd dartushd self-assigned this Oct 24, 2023
bescott1
bescott1 reviewed Oct 24, 2023
View reviewed changes
Copy link

@bescott1 bescott1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dependency for DA3. If you update code here, it will also require publishing a new version same as the sdk

robnewton
robnewton approved these changes Oct 30, 2023
View reviewed changes
Copy link

@robnewton robnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second @bescott1 feedback not to forget a new package release with a version bump

@dartushd dartushd merged commit 86ed0c3 into master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bescott1 bescott1 bescott1 left review comments

@robnewton robnewton robnewton approved these changes

Assignees

@dartushd dartushd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dartushd @robnewton @bescott1