Skip to content

Conversation

@alexbouchardd
Copy link
Contributor

Including the timestamp into the default signature was an oversight.

There's a valid debate around the relevance of timestamp in signatures but our position is that it's security theater as does not effecively protect agaisnt replay attacks (given the need for a validity window). It also leads to more signature verification complexity which in turns results into less users verifying the signatures ultimately leading to less secure systems.

Outpost administrators can still decide to inclue the timestamp is they wish, it's simply not longer the default signature format.

This is a breaking change and to maintain current signature format configs need to be updated with:

DESTINATIONS_WEBHOOK_SIGNATURE_CONTENT_TEMPLATE={{.Timestamp.Unix}}.{{.Body}}
DESTINATIONS_WEBHOOK_SIGNATURE_HEADER_TEMPLATE=t={{.Timestamp.Unix}},v0={{.Signatures | join ","}}

@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
outpost-docs Ready Ready Preview Comment Dec 10, 2025 2:14am
outpost-website Ready Ready Preview Comment Dec 10, 2025 2:14am

@alexbouchardd alexbouchardd changed the title chore: Removing timestamps from default signatures chore: Remove timestamps from default signatures Dec 10, 2025
@alexbouchardd alexbouchardd changed the title chore: Remove timestamps from default signatures chore: Remove timestamps from default signature template Dec 10, 2025
Copy link
Collaborator

@alexluong alexluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's include this in the upcoming release with CH & Log API given it's a pretty big breaking change

also will need some changes in the tests I think but I can take it from here

@alexluong
Copy link
Collaborator

TODO: make sure the generated config md shows the right value for DESTINATIONS_WEBHOOK_SIGNATURE_HEADER_TEMPLATE=t={{.Timestamp.Unix}},v0={{.Signatures | join ","}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants