fix: Prevent lowercase when sluggify #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbouchardd
approved these changes
May 16, 2025
leggetter
reviewed
May 19, 2025
| @@ -180,6 +180,7 @@ func createSource(sdkClient *hookdeckclient.Client, name *string) (*hookdecksdk. | |||
| sourceName = answers.Label | |||
| } | |||
|
|
|||
| slug.Lowercase = false | |||
There was a problem hiding this comment.
@alexluong - any chance this has any side effects elsewhere? For example, does it set Lowercase globally, and if slug is used in some other file/function then the Lowercase setting will be set as true?
Ultimately, I'm assuming we only really want to use the function in Lowercase, but if we do I think we should have a utility function of our own to make it clear that the Lowercase is intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #122