Skip to content

Tex: de-duplicate ultisnips snippets already defined in snipmate format #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

sanjayankur31
Copy link
Contributor

No description provided.

@sanjayankur31
Copy link
Contributor Author

Question: is there value in making sure the ultisnip and snippets commands are the same. Or, on the contrary, is there a reason to make sure they're not the same?

@lpil
Copy link
Contributor

lpil commented Nov 27, 2023

The ultisnips ones should be removed- they should only exist for specific snippets that cannot be implemented using the snipmate format.

@sanjayankur31
Copy link
Contributor Author

Aha, right. I hadn't realised that. I'll update the PR now. Could this please be documented in the Readme under a "contributing" section perhaps, just so future contributors know?

@lpil
Copy link
Contributor

lpil commented Nov 27, 2023

It is already documented, but improvements to the README are welcome.

Remove from ultisnips those that are already defined in snipmate format
@sanjayankur31
Copy link
Contributor Author

Updated to remove UltiSnip snippets that are already defined in the snipmate format.

I couldn't find where in the docs it says to prefer snipmat since UltiSnips can also read them, so I've added a line in the Readme.


snippet chapl "Chapter with label" wi
\chapter{$1${VISUAL}}
\label{cha:${2:${1/\W+/-/g}}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are already defined in snipmate, so I removed them, but the labels here are more advanced, so we could leave these in as UltiSnips specific overrides.

Copy link
Contributor

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit 2ed3a73 into honza:master Nov 27, 2023
@sanjayankur31 sanjayankur31 deleted the feat/latex branch November 27, 2023 12:00
@sanjayankur31 sanjayankur31 changed the title Tex: add modern textbf/textit/texttt commands Tex: de-duplicate ultisnips snippets already defined in snipmate format Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants