fix(mcp): notify onclose when standalone SSE stream aborts - #2075
Open
edenbuilds wants to merge 4 commits into
Open
fix(mcp): notify onclose when standalone SSE stream aborts#2075edenbuilds wants to merge 4 commits into
edenbuilds wants to merge 4 commits into
Conversation
MCP clients often drop the GET SSE stream without DELETE. Call onclose on standalone stream abort so apps can detect disconnects, without double-firing when close() also runs. Fixes honojs#1762
🦋 Changeset detectedLatest commit: f7310a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
==========================================
+ Coverage 92.23% 92.24% +0.01%
==========================================
Files 116 116
Lines 4122 4129 +7
Branches 1077 1079 +2
==========================================
+ Hits 3802 3809 +7
Misses 285 285
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Await stopTestServer and prefer ?? for session ids so @hono/mcp lint passes in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onclosewhen the standalone GET SSE stream (_GET_stream) aborts, so apps can detect client disconnects without relying on DELETE.close()after an abort does not fireonclosetwice.Fixes #1762
Test plan
oncloseonce; subsequentclose()does not double-fireonsessionclosedDELETE tests still passMade with Cursor