feat(cloudflare-workers): modified manifest option to be required #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code-Hex
force-pushed
the
fix/serve-static
branch
from
762ebef
to
5a32d8f
Compare
|
Hi @Code-Hex! I think this change is acceptable, but as I commented in #1127 (comment), it introduces a breaking change. So, we can include it in the next major release, |
yusukebe
changed the title
yusukebe
changed the title
|
Hi @Code-Hex ! I've made |
This was referenced Jan 10, 2024
|
Duplicated #1984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author should do the followings, if applicable
yarn denoifyto generate files for DenoThis is breaking change but fix: #1127 (comment)
To resolve the issue, it may be better not to modify serveStatic (module) directly but to provide the wrapped version of serveStatic. However, I don't have any ideas on how to provide it in that case.