fix(context): set status correctly (#1814)

* fix(context): set `status` correctly * denoify
honojs · Dec 13, 2023 · 4c4c4ee · 4c4c4ee
1 parent a86b75b
commit 4c4c4ee
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/deno_dist/context.ts b/deno_dist/context.ts
@@ -234,7 +234,7 @@ export class Context<
       this.res = new Response(data, arg)
     }
 
-    let status = typeof arg === 'number' ? arg : this.#status
+    const status = typeof arg === 'number' ? arg : arg ? arg.status : this.#status
     this.#preparedHeaders ??= {}
 
     this.#headers ??= new Headers()
@@ -249,7 +249,6 @@ export class Context<
       for (const [k, v] of Object.entries(this.#preparedHeaders)) {
         this.#headers.set(k, v)
       }
-      status = this.#res.status
     }
 
     headers ??= {}

diff --git a/src/context.ts b/src/context.ts
@@ -234,7 +234,7 @@ export class Context<
       this.res = new Response(data, arg)
     }
 
-    let status = typeof arg === 'number' ? arg : this.#status
+    const status = typeof arg === 'number' ? arg : arg ? arg.status : this.#status
     this.#preparedHeaders ??= {}
 
     this.#headers ??= new Headers()
@@ -249,7 +249,6 @@ export class Context<
       for (const [k, v] of Object.entries(this.#preparedHeaders)) {
         this.#headers.set(k, v)
       }
-      status = this.#res.status
     }
 
     headers ??= {}

diff --git a/src/middleware/cors/index.test.ts b/src/middleware/cors/index.test.ts
@@ -65,6 +65,7 @@ describe('CORS by Middleware', () => {
   it('GET default', async () => {
     const res = await app.request('http://localhost/api/abc')
 
+    expect(res.status).toBe(200)
     expect(res.headers.get('Access-Control-Allow-Origin')).toBe('*')
     expect(res.headers.get('Vary')).toBeNull()
   })