feat: Support custom regex parsing s3 logfile #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
status: oncall
kentquirk
removed
the
status: oncall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Injects
REGEX_PATTERNinto lambda environment to be used by https://github.com/honeycombio/agentless-integrations-for-awsAnother PR (#74), seems to have covered this, but added other features as well. Hopefully, keeping this simple will smooth things out.
How to verify that this has the expected result
I am not completely sure how the terraform testing works in the repository. I am happy to write a test with a little direction from a maintainer.
note:
This change was inspired by the desire to have more vpc flowlog fields. It's probably a good idea to add default regex in the
agentless-integrations-for-awsproject. I started doing that, but decided it would be nice to have this feature anyway since custom output is allowed.