Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address pr feedback #11

Merged
merged 5 commits into from
May 9, 2023
Merged

address pr feedback #11

merged 5 commits into from
May 9, 2023

Conversation

pkanal
Copy link

@pkanal pkanal commented May 9, 2023 •
edited
Loading

  • pins versions in example app
  • node 20 support disclaimer
  • re-export hook.mjs file functions 😍

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (esm-support@58d34c0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a6fd6f3 differs from pull request most recent head fc13942. Consider uploading reports for the commit fc13942 to get more accurate results

@@              Coverage Diff               @@
##             esm-support      #11   +/-   ##
==============================================
  Coverage               ?   93.14%           
==============================================
  Files                  ?      229           
  Lines                  ?     5617           
  Branches               ?     1099           
==============================================
  Hits                   ?     5232           
  Misses                 ?      385           
  Partials               ?        0

@pkanal pkanal requested a review from a team May 9, 2023 18:59
@pkanal pkanal self-assigned this May 9, 2023
@pkanal pkanal marked this pull request as ready for review May 9, 2023 19:00
JamieDanielson
JamieDanielson reviewed May 9, 2023
View reviewed changes
experimental/packages/opentelemetry-instrumentation/hook.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

JamieDanielson
JamieDanielson approved these changes May 9, 2023
View reviewed changes
Copy link

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion but otherwise looks good to me!

@pkanal pkanal force-pushed the purvi/more-pr-feedback branch from 181ce00 to fc13942 Compare May 9, 2023 19:42
@pkanal pkanal merged commit 33409da into esm-support May 9, 2023
@pkanal pkanal deleted the purvi/more-pr-feedback branch May 9, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees

@pkanal pkanal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkanal @codecov-commenter @JamieDanielson