feat(hpsf): add ability to produce otlp exporter to honeycomb #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
force-pushed
the
codeboten/add-collector
branch
from
7936c4f to
85b0fdd
Compare
This PR adds the ability to use the HoneycombExporter component template to produce collector configuration to emit otlphttp to honeycomb. It also adds the following: - ability to set slices of maps as values in templates - output tests for a HoneycombExporter Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/add-collector
branch
from
85b0fdd to
d07843e
Compare
MikeGoldsmith
approved these changes
Jan 9, 2025
| The compression to use when sending data to Honeycomb. | ||
| This is normally gzip, but can be overridden. | ||
| type: string | ||
| validations: [nonblank] |
There was a problem hiding this comment.
Does having this as nonblank mean you have to provide a value. Is none okay?
There was a problem hiding this comment.
currently validations are not enforced. none will be ok... i suspect nonblank will just mean don't put an empty string here
Comment on lines
+1
to
+2
| API_Key: ${HONEYCOMB_TRACES_APIKEY} | ||
| API_URL: https://api.honeycomb.io |
There was a problem hiding this comment.
Naming is always fun. There's 3 different forms here; API_Key, AcessKeys and sendKey :|
Suggested change
| API_Key: ${HONEYCOMB_TRACES_APIKEY} | |
| API_URL: https://api.honeycomb.io | |
| ApiKey: ${HONEYCOMB_TRACES_APIKEY} | |
| ApiUrl: https://api.honeycomb.io |
|
I think this is now obsolete and should be closed. Is that correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR adds the ability to use the HoneycombExporter component template to produce collector configuration to emit otlphttp to honeycomb.
Short description of the changes