Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example config & API calls for network events #165

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

MustafaHaddara
Copy link
Contributor

@MustafaHaddara MustafaHaddara commented Jun 6, 2024

Which problem is this PR solving?

Updates our examples to use the ignoreNetworkEvents config option (which was just released today)

Also adds a button that makes an API call so that we can actually see the network spans.

How to verify that this has the expected result

Run locally, look at exported spans, less events:

red rect is on the default config, green rect with ignoreNetworkEvents = true:
image

@MustafaHaddara MustafaHaddara changed the title Add example config & API calls for network events docs: add example config & API calls for network events Jun 6, 2024
@MustafaHaddara MustafaHaddara marked this pull request as ready for review June 6, 2024 18:04
@MustafaHaddara MustafaHaddara requested review from a team as code owners June 6, 2024 18:04
@MustafaHaddara MustafaHaddara merged commit 4582977 into main Jun 18, 2024
8 checks passed
@MustafaHaddara MustafaHaddara deleted the mhaddara/ignore-network-events-config branch June 18, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants