Skip to content
This repository was archived by the owner on Aug 13, 2025. It is now read-only.

Capture exception details in AWS Lambda middleware. #154

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Capture exception details in AWS Lambda middleware. #154

merged 2 commits into from
Jan 21, 2021

Conversation

@fitzoh
Copy link
Contributor

@fitzoh fitzoh commented Jan 19, 2021

Trace field names match the ones used in Tracer:

beeline-python/beeline/trace.py

Lines 74 to 78 in 2ab8dea

span.add_context({
"app.exception_type": str(type(e)),
"app.exception_string": stringify_exception(e),
"app.exception_stacktrace": traceback.format_exc(),
})

closes #153

@fitzoh fitzoh requested a review from a team January 19, 2021 01:23
MikeGoldsmith
MikeGoldsmith approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @fitzoh!

@MikeGoldsmith MikeGoldsmith merged commit 1a7706e into honeycombio:main Jan 21, 2021
@fitzoh fitzoh deleted the lambda-exceptions branch January 21, 2021 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Capture exception details for lambda middleware

2 participants

@fitzoh @MikeGoldsmith