Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show arguments in stacktrace #373

Merged
merged 1 commit into from
Jul 12, 2021
Merged

show arguments in stacktrace #373

merged 1 commit into from
Jul 12, 2021

Conversation

TraceyOnim
Copy link
Contributor

@TraceyOnim TraceyOnim commented Jul 9, 2021

This PR is related to #123
I have found out that, the stack trace is been parsed at this notice.ex line 57 Hence for the limited cases like FunctionClauseError, the arguments are not available for the final output.
Here is the stack trace before been parsed:

{HelloWeb.PageController, :match, [%{}],
   [file: 'lib/hello_web/controllers/page_controller.ex', line: 28]}

After been parsed at notice.ex line 57:

{HelloWeb.PageController, :match, 1,
   [file: 'lib/hello_web/controllers/page_controller.ex', line: 28]}

@TraceyOnim TraceyOnim self-assigned this Jul 9, 2021
@sorentwo
Copy link
Collaborator

@TraceyOnim Nice find!

@sorentwo sorentwo merged commit accd0a1 into master Jul 12, 2021
@sorentwo sorentwo deleted the fix/show_stacktrace_args branch July 12, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants