Swap text colour to make it clear on addrow button #5202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tensounder54
added a commit
to Tensounder54/Reddit-Enhancement-Suite
that referenced
this pull request
Jun 27, 2020
* Replace jquery-sortable with sortablejs (honestbleeps#5076) * Remove `$.sortable` Flow definition * settingsConsole: Fix load message logic * 5.17.1 * nightwatch: Log only actions which fails * tests settingsConsole: Remove broken reorder list test * utils/SelectedThing: Split core functionality from selectedEntry Keeping the core functionality always enabled in the module made it hard to reason about. * utils/PagePhases: Split from core/init Moved to utils since other utils would not otherwise be able use it, as import from core is restricted. * Floater: Move to utils, add support for r2 userbar and tabmenu Moving to utils allows other utils (CreateElement.tabMenu) to utilize it. Builds upon andytuba's changes (7468aab). The extended support lets us specify fallbacks, so floaters can automatically be created in the redesign. * Optimize +subscribe / +dashboard buttons Insert them synchronously, and only update them if their state is non-default (which is unlikely). * r2 init: Tweak hiding elements while loading * hover: new method 'watch' to invoke begin on mouseover Allows us to simplify several of the consumers. * requestPermissions: Get optional permissions programmatically * Replace numeral with Intl.FormatNumber Available in Chrome 77. No ETA for Firefox, but this isn't important enough to polyfill anyway. * nightwatch: Don't use multiple workers (it causes a timeout) Causes longer test times, but at least the tests works. Can be reverted when workers starts working again. * update deps * vreddit: Fix replaceNativeExpando * nightwatch: Restore workers, fix timeout `live_output` (by default `false`) doesn't appear to have been working properly earlier, since the output could be seen live in Travis. However, it suddenly started working without making any changes the Nightwatch. By enabling it, Travis won't timeout anymore waiting for Nightwatch to finish. * jQuery as direct dependency (honestbleeps#5142) * Remove dependency tokenInput tokenInput is only used for auto-completing subreddits in the dashboard, and is not really that useful anymore since it's slow and not that helpful due the number of possible subreddits. * jQuery as direct dependency safeHtml is replaced DOMPurify.santize, to make its usage more transparent and less error-prone. The net result is about the same, as its default options appears to be sufficient for our purposes. The guiders script is modified so that it export `guiders` directly. * Bump min required Chrome version Appears to be necessary in order to improve nightwatch testing reliability. Also removes min Opera version since updating it is doesn't seem worthwhile. * While loading, also hide parents' following siblings. * subredditManager: Make sure not to invoke loggedInUser before sitetableStarted * Run migrations in the background (honestbleeps#5143) Lets RES complete the migrations before the user opens Reddit, to avoid the first visit to Reddit having an inconsistent state. This does however not prevent storage from being accessed by foreground instances while migrating, so if Reddit is opened too early, the old issues may still be apparent. Storage functions in core/options and core/modules are moved to a separate files, storage.js in their respective folders, to avoid having the background bundle ballooning by importing all modules. Due to this, `Options.set` is in many cases replaced with the new interface `Options.save`. * update deps * Add and load fonts instantly * 5.17.2 * Filterline widget: Tweak CSS * showImages video: Restore time when reopening expando * Add focus function to submitHelper.js, fixes honestbleeps#4958 (honestbleeps#5145) * update deps * host flickr: Fix embed, use link src when possible * host codepen: Retrieve iframe src instead of inserting remote HTML * Clean-up some hosts * remove host ctrlv.in: defunct / unused * remove host futurism: broken API * remove host gatherer: defunct / unused * remove host graphiq: unused / broken API * remove host masterypoints: defunct / unused * remove host memegen: defunct / unused / default handler is sufficient * remove host picshd: unused / default handler is sufficient * remove host pornbot: unused / broken API * remove host qwipit: defunct / unused * remove host rawprogress: defunct / unused * showImages: In optional permission propmt, let user disable host * host codepen: Divine src instead of fetching it * Fix showImages test * added peervideo.net to known peertube domains (honestbleeps#5146) * update deps * 5.17.3 * update deps * 5.17.4 * Fix cli RESStorage update * options: Fix storage pruning of default values * commentSortBy: Tweak text * update deps * tests showImages crosspost: Make more reliable * tests Filterline ondemand: Make more reliable * Add expando support for channel-based Twitch clip URL scheme (honestbleeps#5148) * 5.17.5 * filteReddit: Filter user tags (via userTagger) * update deps * readComments: Tweak notification * 5.18.0 * Fix autoHide test * Fix thingHide on native hide buttons * showImages: Fix mediaControls downloads in Chrome * showImages: Reduce sepia on opened expandos * Reencrypt Firefox credentials * notifications: Fix compatability with Toolbox * accountSwitcher: Fix usernames being lowercased * showImages: Simplify sfwHistory * update deps * 5.18.1 * commentTools: Fix table generation * Workaround for some Things not having 'visible' tasks run * 5.18.2 * userTagger: Fix ignore button position * subredditManager: Fix dropdrop getting closed on when sorting * accountSwitcher: Fix otp not getting prompted * Fix hide button showing 'unhidehide' * 5.18.3 * update deps * Fix doNoCtrlF race conditions Some elements has noCtrlF already applied (e.g. RES' hide button). This prevents doNoCtrlF from processing those elements. * dashboard: Fix add/edit subreddit * Updated pixiv host to accept new url format (honestbleeps#5153) * update deps * accountSwitcher: Fix hiding of active account * subredditManager: Fix sorting * ner: Fix returnToPrev * settingsConsole: Limit height of tables * 5.18.4 * removed unused lines from FUNDING.yml * removed users not enrolled in github sponsors I want to figure out a way to re-add andytuba, larsjohnsen, erikdesjardins here - but right now their presence creates an error message with the "Sponsor" button because they're not in the github sponsors program. * Minor CSS fix for button alignments on multis (honestbleeps#5157) Minor CSS adjustment to fix alignment of buttons on url-scheme multireddits (ex: `https://old.reddit.com/r/news+worldnews+politics`). Before and after: https://i.imgur.com/hAYwKUm.gifv * tableSort: Fix numeric sorting * Use Event#currentTarget where appropriate * Fix some code smells * userInfo: Utilize CreateElement#fancyToggleButton * subredditManager: Utilize TableTools * utils/dashboard: Split dashboard tab functionality from module Simplifies some of the tabs: - Using TableTools's for sorting of tables instead of the modules rolling their own - Don't paginate, as that makes finding a certain user hard (though this causes some slowness) * singleClick refactor * update deps * Fix voteEnhancement color sorting * Possible workaround for Firefox viewport-size bug * Restore dashbord pane functionality * update deps * Some clean-up (honestbleeps#5160) * add streamvi.com to hosts (honestbleeps#5162) * 5.18.5 (honestbleeps#5161) * 5.18.5 * Update v5.18.5.md * update deps (honestbleeps#5163) * Fix some Event.currentTarget issues * Fix singleClick refactor typos * 5.18.6 * singleClick: Fix middle click, keyboardNav shortcut * commentTools autoComplete: support hyphen * Fix showImages test * betteReddit fixHideLinks: Fix fadeOut never being invoked * Fix Nightmode issue with removed comments (honestbleeps#5167) * saveComments: Fix delete * update deps * core: Ignore stored values with undefined value There seems to be a bug somewhere which causes `undefined` to be saved as instead of a array / or the value to be set to null. * v5.18.7 * update deps * Fix Streamvi link expansion (honestbleeps#5172) * update deps * showImages: Fix rotation sizing * v5.18.8 * Added visual indication of account switching (honestbleeps#5170) A small change to indicate when an account switch is being processed. * update deps * ner: Words more clear * tests: Update deprectated assertion * hosts: Add redgifs * filterline expando filter: Fix false negative * utils/table: Commonly used table features Cleans up subredditManager a little * update deps * Fix showImages test * 5.18.9 * subredditManager: Fix lastViewtime * update deps * showImages: Restore gallery to filmstrip button * update deps * Tweak pagination in gallery and utils/table * Fix production build reproduciblity * troubleshooter disableRES: Don't navigate to frontpage * 5.18.10 * Fix browser detect for new Edge (honestbleeps#5178) * ner: Fix typo * subredditManager list: Fix lastVisited sorting * Use new google drive api domain (honestbleeps#5182) * changelog 5.18.11 * 5.18.11 * update deps * Update to Discord URL * Fix Thing#getCommentLink signature * requestPermissions: Make description more accurate * Fix nightmode for create sub page. (honestbleeps#5187) * Added RedGIFs as a Host to enable embedding video player (honestbleeps#5174) * Support for redgifs expando * Removed the migration code Co-authored-by: Ben McGarry <9434920+BenMcGarry@users.noreply.github.com> * Liquipedia.net Host Support (honestbleeps#5176) * Initial Liquipedia support Adapted from Wikipedia host * Proper Liquipedia support * Cleanup * Further sccs cleanup * Remove trailing whitespace * Fix forgotten hex color fix * Fix typo and add srcset support * Added API Terms of Use link * nightMode: Add option to follow media query 'prefers-color-scheme: dark' (honestbleeps#5166) * NaverTV host (honestbleeps#5171) * Add files via upload * Update vlive.js * Fix lint * added NaverTV similar to YouTube for Korea * Fix lint. Co-authored-by: Lars <larsjohnsen@gmail.com> Co-authored-by: Ben McGarry <9434920+BenMcGarry@users.noreply.github.com> * Adding futureproof and some css changes (honestbleeps#5190) Adding futureproof removal of elements using custom class. Added some recently added css for items which are commontly included in the included content. * 5131 - Fix logoLink doesn't redirect to /hot/ (honestbleeps#5188) * 5131 - Fix logoLink doesn't redirect to /hot/ Closes honestbleeps#5131 * checkout locales from master * update deps * backupAndRestore: Make file restore more tolerant to varying event order * Fix nightmode on copyright takedowns. (honestbleeps#5192) * Use getRedirectURL in Firefox to fix backups in 75 and later (honestbleeps#5195) Fixes honestbleeps#5184 After this change, OneDrive backups in Firefox are separate from OneDrive backups in other browsers. Microsoft requires that all redirect URIs for an application are on the same domain. In Firefox 75 and later we are forced to use a Mozilla domain like f6be6623b0b4ed4e84464ff8b07afff3c421e497.extensions.allizom.org, which of course is different from redditenhancementsuite.com. So there is now a separate "Reddit Enhancement Suite (for Firefox)" OneDrive application used in Firefox. * update deps * v5.18.12 * Add ~ as defined illegal character. (honestbleeps#5198) Per chromium documentation, ~ is a illegal character and will not allow downloads if this is in the filename. Tested this works on Edge 80. https://github.com/chromium/chromium/blob/master/base/i18n/file_util_icu.cc#L81 * [Snyk] Security upgrade jquery from 3.4.1 to 3.5.0 (honestbleeps#5199) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JQUERY-565129 * Remove Opera deployment * Remove opera creds (honestbleeps#5200) We dont publish to Opera anymore as the version 2 years ago is still pending review. * Remove opera dep module * subredditManager: Fix styling Prevents text wrapping when there's long subreddit names in the list. Add pointer cursors where appropriate. * Swap text colour to make it clear on addrow button (honestbleeps#5202) * Move text colour to make it clear * Remove Host at request of original author due to API issues. (honestbleeps#5204) * Remove Emojis from image downloads (honestbleeps#5203) Chrome gets funny with Emojis blocking downloads, theres no way to know which ones so this just removes all emojis from the title on save. One potential issue is if images have an only emoji title. * v5.18.13 changelog. * 5.18.13 release * Remove pre-push checks. (honestbleeps#5208) They are mismatched against buildservers and can take ages to complete preventing pushes and causing poor UX with the RES repo. * Update yarn.lock file (honestbleeps#5209) * Update deploy docs. * dashboard: Fix fetch URL * Remove liquipedia css. (honestbleeps#5210) * Create SECURITY.md (honestbleeps#5214) * Create SECURITY.md * backupAndRestore: Update Google Drive token retrieval link (honestbleeps#5213) * lockdown extension context CSP * changelog 5.18.14 * 5.18.14 * Add public PGP key. * Code block PGP key. * Update PGP key. * Update SECURITY.md * betteReddit: New option to always display scrollY bar * filteReddit tweaks * Update SECURITY.md * Fix disable autoplay for RedGIFs (honestbleeps#5221) * Update nightmode for happening now box. (honestbleeps#5222) * Add basic tuckbot.tv support (honestbleeps#5225) * Added basic tuckbot.tv support * Add images to be used for store listings. More specific to features and actually fit the resolution requested - 640-400. * Lodash#flow issue workaround This function seems to be incompatible / brokes. In some cases in the initialization process the JS engine complains of it referencing an unknown functions. * update deps * Tweak linting rules for eslint 7 Removes some rules than no longer needs to explicitly disabled. Removes now-broken import / namespace rules. Those doesn't seem to support the plugin `babel-proposal-export-nampspace-from`. * customToggles: Don't expose 'key' value * subredditManager: Fix search field not focusing after first open Fixes honestbleeps#5226 * eslint: Disable seemingly broken rule 'flowtype/semi' * tests: Fix showIimage 'image expando' * Reverse bad flowconfig * tests: Fix showIimage 'image expando' * update deps * regexRegex: Add support for 's' flag * Update Twitter API (honestbleeps#5227) * Update Twitter API * Fix flow * update deps * Simplify lodash setup to reduce load time penalty - lodash and webpack didn't work all that nicely together, resulting in some functions not being correctly compiled, and causing errors on init - Also reduces bundle size with a few kB. - These are savings unfortunately contingent on removing lodash/fp * Bump min required browser versions to allow usage of new features * 5.19.0 * Fix Twitch with latest API changes. (honestbleeps#5232) * console.warn when overwritting option table, list, builder * lodash-es * Prefer to load dependencies as ES modules * update deps * Optimize Filterline * Use location.hostname for twitch. Resolves issue of subdomain. Tested on Edge 83. * lint errors * Fix tests * 5.19.1 * Add GamerDVR and update XboxDVR. (honestbleeps#5234) * update deps * subredditStyleToggle: Remove subreddit logo earlier * filteReddit settings: Add table for filtering by comment content * commentNavigator: Option to remember read comments * filteReddit comments: Add filter for subreddit * subredditManager: Simplify drag & drop code * nightMode / subredditStyleToggle refactor * Update twitchclips for new API. (honestbleeps#5236) * commentNavigator: Disable skipReadComments by default * betteReddit: New option blankPageUntilMeaningfulContent Disabled by default. Often improves load speed by not having the browser spend time on rendering the page before any meaningful content has been inserted into the DOM. * 5.19.2 * commentNavigator: Don't use the ReadComments to track comments ReadComments may be used by autoHide, which also may mark surrounding comments as read, which is not desirable when jumping around the thread. * filteReddit options: Clarify usersMatchRepliesAction description * update deps * Optional permissions: Allow all users to use fallback process * Fix no-promise-executor-return lint errors * fix Chrome beta build * 5.20.0 * Fix nightMode / subredditStyleToggle race condition A change in how nightMode / subredditStyleToggle communicated with each other caused a race condition when nightMode is enabled and the subreddit has a nightMode-compatible theme. When opening a new tab, the new state went through: 1. Turn off custom style, since it could not at that stage be determined that the subreddit supported it 2. Turn it back on when support is estabished This state was broadcasted to every other tab. That was unnecessary, and is now disabled by using the new customToggle mode 'autoLocal'. * filteReddit: Add postAge as default comment filter * nightWatch: Don't invoke callbacks when there's no update * More nightMode/subredditStyleToggle tweaks * v5.20.1 Co-authored-by: larsjohnsen <larsjohnsen@gmail.com> Co-authored-by: Erik <erikdesjardins@users.noreply.github.com> Co-authored-by: Ryan Mahan <ryanmahan97@gmail.com> Co-authored-by: Björn Jürgens <4362465+bjuergens@users.noreply.github.com> Co-authored-by: 1bakedpotato <45945093+1bakedpotato@users.noreply.github.com> Co-authored-by: Aherm <Aherm@users.noreply.github.com> Co-authored-by: Steve Sobel <steve@openingbands.com> Co-authored-by: corylulu <corylulu@gmail.com> Co-authored-by: James Collins <JimboLodisC@users.noreply.github.com> Co-authored-by: Ben McGarry <9434920+BenMcGarry@users.noreply.github.com> Co-authored-by: Nick Koester <nick.koester5@gmail.com> Co-authored-by: Frank Salmick <frank@salmick.com> Co-authored-by: redg-dev <59034484+redg-dev@users.noreply.github.com> Co-authored-by: Martin B <mvbotev@yahoo.co.uk> Co-authored-by: Rando <letb01@hotmail.com> Co-authored-by: Federico Panico <fedemp@users.noreply.github.com> Co-authored-by: Snyk bot <snyk-bot@snyk.io> Co-authored-by: Kyle <kyleratti@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
New: