Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added visual indication of account switching #5170

Merged
merged 10 commits into from
Jan 1, 2020
Merged

Added visual indication of account switching #5170

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c0f5565
Update accountSwitcher.js
FrankSalmick Nov 28, 2019
68df0f8
Update accountSwitcher.js
FrankSalmick Nov 28, 2019
87b934b
Update accountSwitcher.js
FrankSalmick Nov 30, 2019
497bf2c
This will recover gracefully if the ajax calls fails
FrankSalmick Dec 27, 2019
830a807
Removed old code
FrankSalmick Dec 27, 2019
8761f37
Fix lint, don't let child elements override cursor
larsjohnsen Dec 31, 2019
1a1887b
Add missing semicolon
larsjohnsen Dec 31, 2019
bbc31b7
Use CSS
larsjohnsen Dec 31, 2019
9bd26a4
Update accountSwitcher.js
larsjohnsen Dec 31, 2019
958f6c4
Fixed final 2 linting errors
FrankSalmick Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update accountSwitcher.js
  • Loading branch information
@FrankSalmick
FrankSalmick authored Nov 28, 2019
commit 68df0f8936aa3ba0f987812f1e4669989dcc930f
7 changes: 2 additions & 5 deletions lib/modules/accountSwitcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,9 @@ const switchTo = mutex(async (username: string) => {
}

await logoutPromise;

// Provide some form of indication that the account switch is being processed
let oldCursorStyle = document.body.style.cursor;
document.body.style.cursor = "wait";

const oldCursorStyle = document.body.style.cursor;
document.body.style.cursor = 'wait';
const { success, jquery } = await ajax({
method: 'POST',
url: '/api/login',
Expand All @@ -251,7 +249,6 @@ const switchTo = mutex(async (username: string) => {
});

document.body.style.cursor = oldCursorStyle;

if (module.options.updateOtherTabs.value) {
switchedAccountElsewhere(success ? username : null);
}
Expand Down