Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if comment can be collapsed before collapsing it #3951

Merged
merged 3 commits into from
Jan 30, 2017
Merged

Check if comment can be collapsed before collapsing it #3951

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d387052
Check if comment can be collapsed before collapsing it
preethamrn Jan 28, 2017
20885db
back out keyboardNav change
erikdesjardins Jan 30, 2017
94b8aa0
unnecessary null-check and reversed condition
erikdesjardins Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
back out keyboardNav change 
per #3930 (comment)
  • Loading branch information
@erikdesjardins
erikdesjardins committed Jan 30, 2017
commit 20885db8aa2d833fe8d462cbc686bb3f788dce18
3 changes: 0 additions & 3 deletions lib/modules/keyboardNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,9 +1013,6 @@ function toggleChildren() {
// find out if this is a collapsed or uncollapsed view...
let thisToggle = selected.entry.querySelector('a.expand');

// if the collapse/expand comment button is not visible
if (thisToggle && !thisToggle.offsetParent) return;

// check if this is a "show more comments" box, or just contracted content...
const moreComments = selected.entry.querySelector('span.morecomments > a');
if (moreComments) {
Expand Down