updated imgur host to always load gif/gifv/mp4 over https #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref Dupe #3451 |
not all `info` will have a `link` (as Flow so helpfully points out to us :P), and this brings the replacement closer to the usage
erikdesjardins
force-pushed
the
use-https-imgur-gifv
branch
from
f5fb77e to
7de9f80
Compare
|
Thanks! |
|
Since recently, no image from imgur.com will expand on Reddit. Is this because of this? From my location both imgur.com and i.imgur.com have invalid SSL certificates (Chrome says "security certificate is from a.ssl.fastly.net") |
|
@remram44 can you link to a post where the expand doesn't work? |
|
From the front page:
You can see the submitted link is HTTP, and the rewritten link doesn't load. |
|
Works fine for me: What other extension do you have active? |
|
This change only affects .gifv links, so this can't be it. PR comments are not the right place to discuss potential issues, please post to /r/RESissues (preferred) or create a GitHub issue. |
Repository owner
locked and limited conversation to collaborators
Jan 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3635
on another note, should the host module itself maybe always make sure the request is being made over https? or are there hosts that don't support it?
edit (@erikdesjardins): closes #3451