feat(filteReddit): do not filter own posts #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an option to the filteReddit module to prevent filtering of own posts unless explicitly disabled.
jewel-andraia
requested changes
Oct 22, 2016
| @@ -59,6 +59,11 @@ module.options = { | |||
| noconfig: process.env.BUILD_TARGET === 'safari' || process.env.BUILD_TARGET === 'edge', | |||
| description: 'Show a \'filter visited links\' tab at the top of each subreddit, to easily toggle whether to filter visited posts.', | |||
| }, | |||
| exludeOwnPosts: { | |||
There was a problem hiding this comment.
Exclude -- spelling
| const postAuthor = thing.getAuthor().toLowerCase(); | ||
| // No standard marker for my own posts so compare against the logged in user | ||
| const myName = loggedInUser(); | ||
| if (myName && (myName.trim().toLowerCase() === postAuthor)) { |
There was a problem hiding this comment.
I think trim is overkill in this case.
| @@ -827,6 +832,16 @@ function scanEntries(ele) { | |||
| const postFlair = thing.getPostFlairText(); | |||
| const postLink = thing.getPostLink(); | |||
|
|
|||
| // Do not apply any other filters if posts belong to me | |||
There was a problem hiding this comment.
How about moving this above const postTitle, so the function can quit as early as possible?
Move the conditional up to exit the filter loop as early as possible.
|
Looks good, thanks! |
benmcgarry
pushed a commit
to benmcgarry/Reddit-Enhancement-Suite
that referenced
this pull request
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to the filteReddit module to prevent filtering of own posts unless explicitly disabled.
Closes #3018