Improve keyboard navigation (move) responsiveness #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsjohnsen
force-pushed
the
selectedEntry-select-improve
branch
from
5deccb2 to
31ab716
Compare
| } | ||
|
|
||
| let idleCallback; | ||
| const requestIdle = window.requestIdleCallback ? |
There was a problem hiding this comment.
Should probably move this to utils/async.js (maybe not export it for now, until we need something other than idleThrottle in module code)
| const requestIdle = window.requestIdleCallback ? | ||
| window.requestIdleCallback : // XXX Only available in Chrome / Opera | ||
| fn => requestAnimationFrame(() => requestAnimationFrame(fn)); // Approximation for "Don't do anything this frame" | ||
| const runIdle = callback => { |
There was a problem hiding this comment.
IIUC this ensures that the callback will only be called once if runIdle is called multiple times before an idle period.
If so, this abstraction can be exported from async.js as idleThrottle (just like frameDebounce, which should really be "throttle" rather than "debounce").
i.e. we would end up with
const runIdle = idleThrottle(runListeners);
|
❤️ perf profiles |
larsjohnsen
force-pushed
the
selectedEntry-select-improve
branch
from
31ab716 to
be1ca39
Compare
larsjohnsen
force-pushed
the
selectedEntry-select-improve
branch
from
4d91c88 to
c55a537
Compare
larsjohnsen
force-pushed
the
selectedEntry-select-improve
branch
from
c55a537 to
95f96a1
Compare
benmcgarry
pushed a commit
to benmcgarry/Reddit-Enhancement-Suite
that referenced
this pull request
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially noticeable when using NER.
Before:
After:
