Display gold status in userbar( Closes #1915 ) #3485
Conversation
- new module option: showGold (Display gilded icon if current user has gold status) - new module function updateUserSpan (If the user has gold and would like to, display the gilded-icon in the user span.) - basically borrow a bunch of JS from various functions to make everything work smoothly. - new import needed for nice date on hover - also comments for things :)
|
Relates to #1915 |
| if (data.gold_expiration) { | ||
| const today = new Date(); | ||
| const expDate = new Date(data.gold_expiration * 1000); // s -> ms | ||
| $gilded.attr('title', `Until ${expDate.toDateString()} (${formatDateDiff(today, expDate)})`); |
There was a problem hiding this comment.
Nit: import and use formatDate(expDate) instead of expDate.toDateString() here
There was a problem hiding this comment.
Sure thing, I pulled that line from accountSwitcher (L231):
That may need to be modified as well to use formatDate(expDate) instead of toDateString().
There was a problem hiding this comment.
Yep, looks like that needs to be changed. You could open a new PR for that if you want, or I can take care of it.
There was a problem hiding this comment.
I'll take care of it in a separate PR, one sec.
|
FYI if you edit |
- also add appropriate import
|
Looks good to me! We'll get this merged soon, thanks for the contribution. |
|
Thanks! |
…eps#3485) * Display gold status in userbar( Closes honestbleeps#1915 ) - new module option: showGold (Display gilded icon if current user has gold status) - new module function updateUserSpan (If the user has gold and would like to, display the gilded-icon in the user span.)
gold status)
like to, display the gilded-icon in the user span.)
everything work smoothly.
Screenshot of freshly built plugin:
Passes lint & unit tests.
edit:
closes #1915