Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: append beta to beta version numbers #3198

Merged

Conversation

erikdesjardins
Copy link
Collaborator

For future release automation: since they'll be deployed to the same listing as stable RES, they need the suffix.

for future release automation
@erikdesjardins erikdesjardins added this to the v4.7 milestone Jul 25, 2016
@@ -6,7 +6,7 @@
"author": "honestbleeps",
"homepage": "http://redditenhancementsuite.com/",
"license": "GPL-3.0",
"version": "{{prop?version!../package.json}}",
"version": "{{to-string!./getVersion}}",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: jpm warns about the version because it's not valid semver, despite the fact that AMO doesn't even use semver!

For reference, here are the docs suggesting to use 1.1alpha1, which isn't valid (1.1.0-alpha.1 would be), and a published extension with version number 1.7.7b15.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, JPM's requirement for Semver is documented here: https://developer.mozilla.org/en-US/Add-ons/SDK/Tools/package_json

Copy link
Collaborator Author

@erikdesjardins erikdesjardins Jul 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. But amusingly, that page uses 0.1 in its example manifest, the "invalid semver" error message printed by jpm suggests 1.0.0rc4 (edit: seems this is fixed and I need to update jpm), and AMO doesn't even let you submit extensions with a proper semver beta version:
image
Make up your mind Mozilla!

@erikdesjardins erikdesjardins merged commit f95d59e into honestbleeps:master Jul 25, 2016
@erikdesjardins erikdesjardins deleted the firefox-beta-suffix branch July 25, 2016 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants