eslint: prevent the use of the alert global

honestbleeps · Jul 24, 2016 · fbe6e37 · fbe6e37
1 parent 512f5f8
commit fbe6e37
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -174,9 +174,9 @@
 		"no-prototype-builtins": 0,
 		"no-redeclare": 2,
 		"no-regex-spaces": 2,
-		"no-restricted-globals": 0,
+		"no-restricted-globals": [2, "alert"],
 		"no-restricted-imports": [2, "jquery"], // import it from vendor/ instead
-		"no-restricted-modules": 0,
+		"no-restricted-modules": 0, // see import/no-nodejs-modules
 		"no-restricted-syntax": [2, "ForStatement"], // use for..of or Array.prototype methods
 		"no-return-assign": 2,
 		"no-script-url": 2,

diff --git a/lib/modules/commandLine.js b/lib/modules/commandLine.js
@@ -444,7 +444,7 @@ registerCommand('userinfo', false,
 		if (val.length <= 1) {
 			return 'No username specified.';
 		} else {
-			ajax({ url: string.encode`/user/${val}/about.json` }).then(alert);
+			ajax({ url: string.encode`/user/${val}/about.json` }).then(Alert.open);
 		}
 	}
 );