Added to-do note about unicode

homebysix · Mar 18, 2019 · 0e03c80 · 0e03c80
1 parent b430d0e
commit 0e03c80
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/scripts/recipe_robot_lib/inspect.py b/scripts/recipe_robot_lib/inspect.py
@@ -989,7 +989,9 @@ def inspect_disk_image(input_path, args, facts):
                     except shutil.Error:
                         pass
                 # Unmount attached volume when done.
-                cmd = '/usr/bin/hdiutil detach "%s"' % dmg_mount
+                # TODO: Handle unicode characters here. Example:
+                # http://download.ap.bittorrent.com/track/stable/endpoint/utmac/os/osx
+                cmd = '/usr/bin/hdiutil detach "{}"'.format(dmg_mount)
                 exitcode, out, err = get_exitcode_stdout_stderr(cmd)
                 facts = inspect_app(cached_app_path, args, facts)
                 break