Check that pkg.maintainers is defined before checking it's length

[PatrickStankard]

♻️ Current situation

For some reason, NPM doesn't seem to be setting the maintainers key on packages in the registry right now. I only noticed this because I was seeing this error in the Homebridge UI after publishing an update to a package:

[6/20/2024, 6:17:45 PM] [Homebridge UI] [homebridge-fujitsu-airstage] Failed to check registry.npmjs.org for updates: "Cannot read properties of undefined (reading 'length')" - see https://homebridge.io/w/JJSz6 for help.

💡 Proposed solution

Check that pkg.maintainers is defined before checking it's length

[bwp91]

lgtm thanks!

[ebaauw]

Patched my environment with this fix. The source also seems to end up in dist/main.js, from where the error is caught - I still don't understand typescript in full.

Anyways, this PR solves the missing menu items, but doesn't solve the missing author. The author still seems to be in the response, under _npmUser/name.

[PatrickStankard]

It’s supposed to be set on the NPM side automatically, according to this:

npm also sets a top-level "maintainers" field with your npm user info.

I filed a support ticket with them and started a thread on their GitHub community page, here, if you all want to comment there

[ebaauw]

maintainers is still there on the top level of a package; it's no longer included at the version level of recently published versions. So when only getting the latest version of a package, the info is missing.

[mkz212]

If you want to fix errors in plugins (until this patch will be released) you need to:

• add to package.json: "maintainers": ["maintainer-name"]
• publish latest release (not beta)

I think that this patch should be released ASAP, cause every new public release without maintainers in package.json will generate errors.

And maybe not only first maintainer? Maybe first 4 maintainers?

[ebaauw]

@mkz212's workaround seems to work. Note that it's actually "maintainers": ["maintainer-name"] (using a colon instead of an equals sign).

[mkz212]

@mkz212's workaround seems to work. Note that it's actually "maintainers": ["maintainer-name"] (using a colon instead of an equals sign).

Sorry, yes, colon!

[donavanbecker]

4.56.3 should be released soon.

[donavanbecker]

Ran into a test coverage issue that needs to be resolved first