Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add systemd-resolved Advertiser to UI #1430

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Add systemd-resolved Advertiser to UI #1430

merged 1 commit into from
Nov 10, 2022

Conversation

elyscape
Copy link

@elyscape elyscape commented Nov 9, 2022 •
edited
Loading

This is based on #1427. It addresses the feedback given there and simplifies the code somewhat.

See-also: homebridge/homebridge#3224
See-also: homebridge/HAP-NodeJS#965

Closes: #1427

cc: @Supereg

Supereg
Supereg approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing the feedback 🎉

@oznu oznu merged commit c03ab71 into homebridge:master Nov 10, 2022
@elyscape elyscape deleted the support-resolved-advertiser branch November 10, 2022 23:58
justg5594
justg5594 reviewed Jan 27, 2023
View reviewed changes
Copy link

@justg5594 justg5594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Patr-ick Patr-ick mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justg5594 justg5594 justg5594 left review comments

@Supereg Supereg Supereg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elyscape @Supereg @justg5594 @oznu @donavanbecker