Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setNoDelay call to response socket #968

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Sep 17, 2022

♻️ Current situation

Currently, we set the setNoDelay tcp option for our internal http/tcp server, running for every connection.
This seemingly causes issues as identified in homebridge/homebridge#3226 (comment).
Particularly, according to the documentation, the property response.connection might be nulled once response.end() was called on it.

💡 Proposed solution

This PR removes this call, as request.socket and response.connection are the same object anyways.

⚙️ Release Notes

  • Fixed a potential crash occurring in some rare situations when handling http requests.

➕ Additional Information

Testing

--

Reviewer Nudging

--

@github-actions github-actions bot added the fix label Sep 17, 2022
@coveralls
Copy link

coveralls commented Sep 17, 2022

Pull Request Test Coverage Report for Build 3072448646

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 51.683%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/util/eventedhttp.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib/util/eventedhttp.ts 1 21.66%
Totals Coverage Status
Change from base Build 3043933152: -0.07%
Covered Lines: 5715
Relevant Lines: 10090

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants