Remove setNoDelay call to response socket #968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Currently, we set the
setNoDelay
tcp option for our internal http/tcp server, running for every connection.This seemingly causes issues as identified in homebridge/homebridge#3226 (comment).
Particularly, according to the documentation, the property
response.connection
might be nulled once response.end() was called on it.💡 Proposed solution
This PR removes this call, as
request.socket
andresponse.connection
are the same object anyways.⚙️ Release Notes
➕ Additional Information
Testing
--
Reviewer Nudging
--