Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround avahi issues on synology platform #1003

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Apr 30, 2023

♻️ Current situation

As described in #993 there are issues with avahi advertiser feature introduced in #970 where we detect avahi-daemon restarts.
This feature fails on synology platforms and causes the whole advertiser to fail.

💡 Proposed solution

This PR introduces a workaround to be able to start the advertiser even when the restart listener is not in place.

⚙️ Release Notes

  • Introduced a workaround for issues with avahi advertiser on Synology

➕ Additional Information

Testing

--

Reviewer Nudging

--

@Supereg Supereg changed the title Workaround avahi issues on synology platform (see #993) Workaround avahi issues on synology platform Apr 30, 2023
@github-actions github-actions bot added the fix label Apr 30, 2023
@Supereg Supereg enabled auto-merge (squash) April 30, 2023 16:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4845308173

  • 0 of 9 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 65.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/Accessory.ts 0 3 0.0%
src/lib/Advertiser.ts 0 6 0.0%
Totals Coverage Status
Change from base Build 4845298427: -0.03%
Covered Lines: 7396
Relevant Lines: 10594

💛 - Coveralls

@Supereg Supereg disabled auto-merge April 30, 2023 16:29
@Supereg Supereg merged commit 6df7ecb into beta-0.11.1 Apr 30, 2023
@Supereg Supereg deleted the fix/synology-avahi-issue branch April 30, 2023 16:30
@ebaauw
Copy link
Contributor

ebaauw commented Apr 30, 2023

On my DiskStation running DSM 7.1.1-42962 Update 5, using avahi as advertiser still gives an error on startup:

[4/30/2023, 9:33:19 PM] Homebridge v1.6.1 (HAP v0.11.1) (ds2) is running on port 51826.
Failed to create listener for avahi-daemon server state. The system will not be notified about restarts of avahi-daemon and will therefore stay undiscoverable in those instances. Error message: Error: No such interface found

But I do see the mDNS advertisement in Discovery.

For reference, v1.6.0 gives:

[4/30/2023, 9:39:59 PM] Homebridge v1.6.0 (HAP v0.11.0) (ds1) is running on port 51826.
Could not create mDNS advertisement. The HAP-Server won't be discoverable: Error: No such interface found

And results in no mDSN advertisement.

Both versions issue no errors and show mDNS advertisements when using ciao instead.

@Supereg
Copy link
Member Author

Supereg commented Apr 30, 2023

That is expected when you look at the source code changes.
In the end it is a workaround as nobody could identify the real issue behind us not being able to acquire the dBus interface on synology.

I think just printing a warning is the best case for now.

@Supereg
Copy link
Member Author

Supereg commented Apr 30, 2023

1.6.1 basically restore the functionality pre 1.6.0 (not being able to detect restarts).

@Rikezzz
Copy link

Rikezzz commented Sep 16, 2023

This update also update node.js?
how to update it node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants