1.1.0 #31
Merged
1.1.0 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to review it, or should I just merge? |
|
Go ahead an merge! Awesome work. Thanks for keeping this going. I won’t have time to review it but assume you’ve tested it.
…
On Sep 28, 2023 at 12:13 AM, <rlippmann ***@***.***)> wrote:
Do you want to review it, or should I just merge?
—
Reply to this email directly, view it on GitHub (#31 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAQY4XHIFKIWY5WNGZBSC6DX4UPSJANCNFSM6AAAAAA5KPNPXM).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Thanks, I've tried. There's a couple of cases I have no idea how to test (like getting HTTP error codes 429 and 503) in real life. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Ryan,
Made a lot of improvements, but kind of got distracted finishing up.
I put in automatic relogin (since it seems that ADT will kick you out after a few hours otherwise), and created dataclasses for alarm/gateway so these can be used in HA.