Skip to content

Conversation

@mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Dec 11, 2025

Proposed change

A dependency is installing pycares 5.0.0 and Supervisor's CI suite cannot run with that version. The pytest suite specifically cannot run and raises errors like this: https://github.com/home-assistant/supervisor/actions/runs/20123595726/job/57748682903?pr=6418

Pinning package to a working version range for now to unblock CI.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:
  • Link to client library pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

@mdegat01 mdegat01 added the ci Changes to our CI configuration files and scripts label Dec 11, 2025
@mdegat01 mdegat01 changed the title Test fix pycares dependency <5.0.0 Fix pycares dependency to >=4.0.0,<5.0.0 Dec 11, 2025
@mdegat01 mdegat01 added bugfix A bug fix and removed ci Changes to our CI configuration files and scripts labels Dec 11, 2025
@bdraco
Copy link
Member

bdraco commented Dec 11, 2025

FYI aio-libs/aiodns#218

@mdegat01
Copy link
Contributor Author

Ah so that's what's bringing it in. Ok we'll pin it for now and keep an eye on aiodns for that update. Thanks @bdraco !

@mdegat01 mdegat01 requested a review from sairon December 11, 2025 22:03
@bdraco
Copy link
Member

bdraco commented Dec 11, 2025

I think in the short term you can bump to aiodns 3.6.1 which has the pin

@sairon
Copy link
Member

sairon commented Dec 11, 2025

Okay, lets close it in favor of #6423.

@bdraco
Copy link
Member

bdraco commented Dec 11, 2025

Also could use an opinion on the discussion in the PR

aio-libs/aiodns#218

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants