Refactor widget view layout and update corner radius constants #4268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored WidgetBasicView to improve layout handling for compact and single-column widgets, including max height constraints and dynamic spacing. Moved corner radius logic in TileCardStyleModifier to a computed property for clarity. Updated DesignSystem corner radius constants for better documentation and added missing values.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors widget tile layout behavior (especially for compact/single-column cases) and standardizes corner-radius usage by expanding DesignSystem.CornerRadius and simplifying widget tile styling code.
Changes:
- Updated
WidgetBasicViewlayout to better handle compact widgets (max height constraint, top alignment, and single-item row balancing). - Refactored
TileCardStyleModifiercorner radius logic into a computed property. - Expanded and documented
DesignSystem.CornerRadius, adding missing values (e.g.,twoAndHalf).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/Shared/DesignSystem/DesignSystem.swift | Adds/organizes corner radius constants and improves inline documentation. |
| Sources/Extensions/Widgets/Common/WidgetBasicView.swift | Refines widget tile layout with family-aware constraints and updated corner radius constant usage. |
| Sources/Extensions/Widgets/Common/TileCardStyleModifier.swift | Extracts corner radius decision into a computed property for reuse/clarity. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored WidgetBasicView to improve layout handling for compact and single-column widgets, including max height constraints and dynamic spacing. Moved corner radius logic in TileCardStyleModifier to a computed property for clarity. Updated DesignSystem corner radius constants for better documentation and added missing values.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes