Simplify database updates by replacing upserts with full deletes #4267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors area, entity, and device registry persistence methods to delete all existing records for a server before inserting fresh data, instead of performing upserts and differential deletes. This simplifies the logic and ensures data consistency by always replacing old data in a single transaction.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the database persistence strategy for areas, entities, and device registries by replacing the complex upsert-and-differential-delete approach with a simpler delete-all-then-insert pattern. This change simplifies the code while maintaining data consistency through GRDB's transaction guarantees.
Changes:
- Replaced upsert operations (
save(db, onConflict: .replace)) with insert operations (insert(db)) - Removed logic for fetching existing IDs and computing differential deletes
- Updated method documentation to reflect the new approach
- Applied the pattern consistently across four database persistence methods
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4267 +/- ##
=======================================
Coverage ? 43.22%
=======================================
Files ? 261
Lines ? 15065
Branches ? 0
=======================================
Hits ? 6512
Misses ? 8553
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors area, entity, and device registry persistence methods to delete all existing records for a server before inserting fresh data, instead of performing upserts and differential deletes. This simplifies the logic and ensures data consistency by always replacing old data in a single transaction.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes