Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added doc for name parameter #5848

Merged
merged 1 commit into from
Jul 22, 2018
Merged

Added doc for name parameter #5848

merged 1 commit into from
Jul 22, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jul 21, 2018

Pull request in home-assistant (if applicable): home-assistant/core#15600

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost assigned cdce8p Jul 21, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Jul 21, 2018
@cdce8p cdce8p mentioned this pull request Jul 21, 2018
Merged
4 tasks
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch has-parent This PR has a parent PR in a other repo labels Jul 21, 2018
fabaff
fabaff approved these changes Jul 22, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 67c64b1 into home-assistant:next Jul 22, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jul 22, 2018
@cdce8p cdce8p deleted the bugfix-homekit branch July 23, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@cdce8p cdce8p

Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @fabaff @frenck