-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cloudflare supporting IPv6 in DNS records #35770
base: next
Are you sure you want to change the base?
Update Cloudflare supporting IPv6 in DNS records #35770
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough📝 WalkthroughWalkthroughThe documentation for the Cloudflare integration has been updated to reflect an enhancement in its functionality, specifically regarding the types of DNS records it can manage. The integration now supports both A records and AAAA records, expanding its capabilities. Additionally, the limitations section has been revised to clarify this change, while other aspects of the documentation, such as API token requirements and TLD restrictions, remain unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CloudflareIntegration
participant CloudflareAPI
User->>CloudflareIntegration: Request to update DNS record
CloudflareIntegration->>CloudflareAPI: Update A or AAAA record
CloudflareAPI-->>CloudflareIntegration: Confirmation of update
CloudflareIntegration-->>User: Notify update success
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is targeting and is based of an incorrect branch.
Please target and base this branch of the next
branch. Git rebase your changes onto next
is needed.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
b8529d7
to
c0c9091
Compare
I've taken care of it. Apologies for the confusion, it's my first time submitting a PR. Thanks for your understanding! 😊 |
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit