Update tradfri installation instructions #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be against the current branch? |
|
I wasn't sure if we usually cherry pick or back merge? I can switch if necessary. |
leppa
reviewed
Oct 8, 2017
source/_components/tradfri.markdown
Outdated
| $ make install | ||
| python3 -m pip install cython | ||
|
|
||
| cd /usr/src/app/ |
There was a problem hiding this comment.
Not everybody has /usr/src/app. This script will fail for them. I'd either mkdir it or use /tmp. The source is not needed after the installation, anyway.
fabaff
reviewed
Oct 8, 2017
source/_components/tradfri.markdown
Outdated
| $ ./configure --disable-documentation --disable-shared --without-debug CFLAGS="-D COAP_DEBUG_FD=stderr" | ||
| $ make | ||
| $ make install | ||
| python3 -m pip install cython |
There was a problem hiding this comment.
This should be done inside the venv if there is any.
fabaff
reviewed
Oct 8, 2017
source/_components/tradfri.markdown
Outdated
|
|
||
| git clone --depth 1 https://git.fslab.de/jkonra2m/tinydtls | ||
| cd tinydtls | ||
| autoreconf |
There was a problem hiding this comment.
This requires that autoconf is available which as it was in the old instructions.
There was a problem hiding this comment.
On Fedora, and I guess on CentOS as well, is automake required too.
fabaff
added
Enhancement
Hacktoberfest
4 tasks
…tant.github.io into update_tradfri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update instructions for aiocoap installation.
Pull request in home-assistant (if applicable): home-assistant/core#7815