-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust text for Webmin breaking change in 2024.6 post #33164
Adjust text for Webmin breaking change in 2024.6 post #33164
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
WalkthroughWalkthroughThe recent update addresses the issue of duplicate entities caused by changes in unique IDs within Webmin. Users are advised to remove obsolete entities to resolve these duplicates. No modifications were made to the declarations of exported or public entities. Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional context usedLanguageTool
Markdownlint
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @TheJulianJES 👍
../Frenck
Proposed change
This PR adjusts the text for the Webmin backward-incompatible change in the 2024.6 release post.
Slightly more information is added to inform the user of the actual change, without adding too many details.
Addresses #33098 (comment)
For now, I've mentioned the unique ID change, as it gives more information on the background of the change and some users can probably understand it to also get an idea.
If we really do not want to mention the "unique ID" change at all, these are some possible alternatives:
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit