Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event platform to rfxtrx docs #31636

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Add event platform to rfxtrx docs #31636

merged 4 commits into from
Mar 20, 2024

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Feb 26, 2024 •
edited
Loading

Proposed change

Add mention of event entities for rfxtrx devices.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Feb 26, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 4c2b227
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/65e1f46f7b365800080c3e58
😎 Deploy Preview https://deploy-preview-31636--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elupus elupus mentioned this pull request Feb 26, 2024
Merged
20 tasks
@home-assistant home-assistant bot added the has-parent This PR has a parent PR in a other repo label Feb 26, 2024
@elupus elupus marked this pull request as ready for review February 26, 2024 20:29
@home-assistant home-assistant bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Feb 26, 2024
@klaasnicolaas klaasnicolaas changed the title Add event mention to rfxtrx Add event platform to rfxtrx docs Mar 1, 2024
@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed in-progress This PR/Issue is currently being worked on labels Mar 1, 2024
@home-assistant home-assistant bot marked this pull request as draft March 1, 2024 01:26
@home-assistant
Copy link

home-assistant bot commented Mar 1, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

elupus and others added 2 commits March 1, 2024 07:21
@elupus @klaasnicolaas
Update source/_integrations/rfxtrx.markdown
0f25e74 
Co-authored-by: Klaas Schoute <klaas_schoute@hotmail.com>
@klaasnicolaas
Revert suggestion
fec81e8
@klaasnicolaas klaasnicolaas marked this pull request as ready for review March 1, 2024 15:13
@home-assistant home-assistant bot requested a review from klaasnicolaas March 1, 2024 15:13
klaasnicolaas
klaasnicolaas requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake, as well as was fine. Sorry!

source/_integrations/rfxtrx.markdown Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft March 1, 2024 15:29
@klaasnicolaas klaasnicolaas marked this pull request as ready for review March 1, 2024 15:30
@home-assistant home-assistant bot requested a review from klaasnicolaas March 1, 2024 15:30
klaasnicolaas
klaasnicolaas approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged 👍

@klaasnicolaas klaasnicolaas added the awaits-parent Awaits the merge of an parent PR label Mar 1, 2024
@frenck frenck added the parent-merged The parent PR has been merged already label Mar 20, 2024
c0ffeeca7
c0ffeeca7 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elupus and @klaasnicolaas 👍

@c0ffeeca7 c0ffeeca7 merged commit a365e78 into home-assistant:next Mar 20, 2024
6 checks passed
@home-assistant home-assistant bot removed parent-merged The parent PR has been merged already awaits-parent Awaits the merge of an parent PR labels Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klaasnicolaas klaasnicolaas klaasnicolaas approved these changes

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
Documentation PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elupus @klaasnicolaas @c0ffeeca7 @frenck