Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config Flow to Obihai #26354

Merged
merged 3 commits into from
Mar 4, 2023

Conversation

ejpenney
Copy link
Contributor

@ejpenney ejpenney commented Feb 23, 2023

Proposed change

Adding config_flow to the Obihai integration, deprecate YAML configuration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@ejpenney ejpenney requested a review from dshokouhi as a code owner February 23, 2023 22:36
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Feb 23, 2023
@ejpenney ejpenney force-pushed the ejpenney_obihai_config_flow branch from 9aba583 to 49d0a14 Compare February 23, 2023 22:43
@ejpenney
Copy link
Contributor Author

ejpenney commented Feb 24, 2023

Ended up re-creating the PR because I wanted a more descriptive branch name. Gonna have 3 docs PRs related to this feature, and who knows how long they'll take to get through, so this way future-me can keep better track.

@ejpenney

This comment was marked as abuse.

@dshokouhi
Copy link
Member

@ejpenney I do not usually review PRs in this repo and I think for Config Flow PRs there may need to be a flag at the top to indicate a config flow is added

ha_config_flow: true

I am also not sure if the docs should continue to mention the YAML configuration since its being deprecated.

@frenck frenck added the parent-merged The parent PR has been merged already label Feb 27, 2023
@ejpenney
Copy link
Contributor Author

ejpenney commented Feb 27, 2023

I don't think it's still mentioning the YAML config? We still describe the three required input fields, but it's not in the context of YAML anymore. Unless you see something I don't.

Anyways, I guess I don't understand the process here. Who should give the PR a review then? The automation seems to believe it should be codeowners, but I see that's not the case.

@ejpenney ejpenney changed the title Adding Config Flow to Obihai Add Config Flow to Obihai Feb 28, 2023
source/_integrations/obihai.markdown Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Mar 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 4, 2023 14:20
@ejpenney ejpenney force-pushed the ejpenney_obihai_config_flow branch from af7ea5e to c5c5ff1 Compare March 4, 2023 17:07
@ejpenney ejpenney marked this pull request as ready for review March 4, 2023 17:10
@home-assistant home-assistant bot requested a review from frenck March 4, 2023 17:10
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ejpenney 👍

../Frenck

@frenck frenck merged commit 4fda11e into home-assistant:next Mar 4, 2023
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Mar 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants