-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Config Flow to Obihai #26354
Add Config Flow to Obihai #26354
Conversation
9aba583
to
49d0a14
Compare
Ended up re-creating the PR because I wanted a more descriptive branch name. Gonna have 3 docs PRs related to this feature, and who knows how long they'll take to get through, so this way future-me can keep better track. |
This comment was marked as abuse.
This comment was marked as abuse.
@ejpenney I do not usually review PRs in this repo and I think for Config Flow PRs there may need to be a flag at the top to indicate a config flow is added
I am also not sure if the docs should continue to mention the YAML configuration since its being deprecated. |
I don't think it's still mentioning the YAML config? We still describe the three required input fields, but it's not in the context of YAML anymore. Unless you see something I don't. Anyways, I guess I don't understand the process here. Who should give the PR a review then? The automation seems to believe it should be codeowners, but I see that's not the case. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
af7ea5e
to
c5c5ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ejpenney 👍
../Frenck
Proposed change
Adding config_flow to the Obihai integration, deprecate YAML configuration.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.