Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VeSync Fans #13590

Merged
merged 4 commits into from
Sep 4, 2020
Merged

Add support for VeSync Fans #13590

merged 4 commits into from
Sep 4, 2020

Conversation

TheGardenMonkey
Copy link
Contributor

@TheGardenMonkey TheGardenMonkey commented May 25, 2020

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label May 25, 2020
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in a other repo label May 25, 2020
@frenck frenck changed the title Add documentation to support new Fan capabilities Add support for VeSync Fans May 25, 2020
@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 25, 2020
@frenck frenck assigned TheGardenMonkey and unassigned frenck May 25, 2020
@frenck
Copy link
Member

frenck commented May 25, 2020

@TheGardenMonkey This PR should be targeting the next branch. Please change the target branch and rebase the PR if needed 👍

@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@TheGardenMonkey TheGardenMonkey changed the base branch from current to next May 25, 2020 21:57
@SirDeadlystrike
Copy link

This PR needs to be rebased, you caught the code of conduct commits in your merge.

@klaasnicolaas klaasnicolaas added next This PR goes into the next branch new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch current This PR goes into the current branch in-progress This PR/Issue is currently being worked on labels Jun 21, 2020
@probot-home-assistant probot-home-assistant bot added the parent-merged The parent PR has been merged already label Sep 4, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TheGardenMonkey 👍

@frenck frenck merged commit 143913a into home-assistant:next Sep 4, 2020
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Sep 4, 2020
@TheGardenMonkey TheGardenMonkey deleted the patch-1 branch September 4, 2020 15:54
epenet pushed a commit to epenet/home-assistant.io that referenced this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants