Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart height #24028

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix chart height #24028

merged 1 commit into from
Feb 3, 2025

Conversation

MindFreeze
Copy link
Contributor

@MindFreeze MindFreeze commented Feb 2, 2025

Proposed change

Turns out the issue with 400px was that we should have used Math.min instead of max but even that is not needed as max-height is set in CSS. Grid layout cards now overwrite that max so users can expand charts at will.

I also increased the max back halfway to 350px so we don't change History and expanded more-info too much compared to before.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit ac3796e into dev Feb 3, 2025
16 checks passed
@bramkragten bramkragten deleted the chart-height branch February 3, 2025 10:21
@bramkragten bramkragten added this to the 2025.2 milestone Feb 5, 2025
bramkragten pushed a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants