Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use handle icon for drag and drop in energy devices settings #23933

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jan 29, 2025

Proposed change

Use handle icon for drag and drop in energy devices settings
It was impossible to scroll on mobile because of the full draggable row. This PR replaces the state icon by a drag and drop. It also improve the discoverability of the feature.
The state icon wasn't really useful as, most of the time, the icon is a power icon and it is not displayed in the energy dashboard.

CleanShot 2025-01-29 at 09 19 26@2x

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the import of ha-state-icon

@MindFreeze MindFreeze enabled auto-merge (squash) January 29, 2025 10:59
@MindFreeze MindFreeze merged commit dd64d88 into dev Jan 29, 2025
11 checks passed
@MindFreeze MindFreeze deleted the energy-device-handle-drag-and-drop branch January 29, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants